googleapis / googleapis/google-api-nodejs-client
Should `sideEffects` be boolean `false` ? esbuild is complaining about it since the 128.0.0 release:
Open
- Dominant language
- TypeScript
- Stars
- 12.2k
- Forks
- 2k
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 24
Description
Should `sideEffects` be boolean `false` ? esbuild is complaining about it since the 128.0.0 release:
```
▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]
./node_modules/googleapis/package.json:9:17:
9 │ "sideEffects": "false",
╵ ^
1 warning
```
[Webpack documents it](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free) similarly as `boolean | string[]`
_Originally posted by @mhio in https://github.com/googleapis/google-api-nodejs-client/issues/3354#issuecomment-1776999824_
Contributor guide
Assessment
This issue has not been assessed yet.