googleapis / googleapis/google-api-java-client

Exponential backoff can't be enabled for clients with credentials

未关闭
#2,512 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
priority: p3 type: feature request
主要语言
Java
星标
1.5k
派生
772
平均合并
1 小时 44 分钟
30 天内合并 PR
1

描述

Hello,

I've got a service which recently ran into issues. One of the AIs from the postmortem is that we should make sure that API client users use exponential backoff by default.

Currently, in order to enable exponential backoff you need to explicitly configure the HttpRequestInitializer object when creating the client interface. For example (from one of my tests):

```
var RETRYABLE_ERROR_CODES = ImmutableSet.of(403, 429);

return new Calendar.Builder(
transport,
GsonFactory.getDefaultInstance(),
/* httpRequestInitializer= */ request ->
request.setUnsuccessfulResponseHandler(
new HttpBackOffUnsuccessfulResponseHandler(new ExponentialBackOff())
.setBackOffRequired(
r -> RETRYABLE_ERROR_CODES.contains(r.getStatusCode()))))
[...elided...]
.build();
```

Except, in real life you're passing a GoogleAccountCredential object as the HttpRequestInitializer. This sets its own unsuccessful response handler (set in https://github.com/googleapis/google-api-java-client/blob/dd333371990ced9c76faba443bdb1b3738915410/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java#L152, with the request handler at the bottom of the same class). While this does have its own backoff configuration, this is used only for the Oauth token fetch, and the unsuccessful response handler can't be configured.

This all seems extremely wrong. I don't see a way in which a client can use a credential _and_ configure exponential backoff, let alone by default. Our examples (e.g. https://developers.google.com/api-client-library/java) don't include any form of exponential backoff; I had to debug my way through the client code to find out it was supported at all.

Am I missing anything here?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。