googleapis / googleapis/google-api-java-client

GoogleAuthorizationCodeFlow Won't Work With non-AppEngine

Aberta
#2,256 2 comentários 0 reações 0 responsáveis Ver no GitHub
priority: p3 type: feature request
Linguagem predominante
Java
Estrelas
1.5k
Forks
772
Merge médio
1h 44min
PRs com merge (30d)
1

Descrição

https://developers.google.com/api-client-library/java/google-api-java-client/oauth2

The `GoogleAuthorizationCodeFlow` class needs, for persistence, a `DataStoreFactory`. However, this appears to be accessible only with AppEngine because the Cloud-Run library provides instead a `DatastoreFactory` (small S).

This dependency goes down event into the `AuthorizationCodeFlow` base class making it (seemingly) impossible for me to create a custom derived class that manages the persistence on my terms.

It would be nice if the base class was independent of the storage type, using function calls that can be overridden.

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Start with the OAuth2 guide and inspect GoogleAuthorizationCodeFlow and its AuthorizationCodeFlow base class, focusing on how DataStoreFactory is required for persistence. Compare that dependency with the DatastoreFactory available to Cloud Run users; done would mean agreeing on and implementing a storage-independent extension point, with tests showing persistence can be supplied without App Engine.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
java
Domínio
authentication
Tipo de issue
Refatoração
Dificuldade
5/5
Tempo estimado
Mais de uma semana
Status de atividade
Estagnada
Clareza
Precisa de esclarecimento
Facilidade para iniciantes
25/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.