googleapis / googleapis/google-api-java-client

How can we move .github/workflows/ci.yaml back to synthtool's template?

未关闭
#1,720 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
priority: p4 type: process
主要语言
Java
星标
1.5k
派生
772
平均合并
1 小时 44 分钟
30 天内合并 PR
1

描述

As synthtool's template does not call `.kokoro/install_dependencies.sh `, I had to exclude ci.yaml from synthtool's management: https://github.com/googleapis/google-api-java-client/pull/1699/files#diff-c881f5091bb23fef16e6e6da031e4268bbb11bb3404c1a2c7da8afa53c26f4ecL32.

# What's missing in synthtool's template

## install_dependencies is not called.

How about the following options?

- build.sh to call install_dependencies.sh if it exists
- GitHub actions (ci.yaml) to call install_dependencies.sh if it exists

Does install_dependencies.sh work in Windows?

## Synthtool's template is missing to disable CRLF conversion.

```
- name: git configuration to avoid automatic CRLF conversion
run: |
git config --global core.autocrlf false
git config --global core.eol lf
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。