googleapis / googleapis/google-api-java-client

How can we move .github/workflows/ci.yaml back to synthtool's template?

Open
#1,720 0 comments 0 reactions 0 assignees View on GitHub
priority: p4 type: process
Dominant language
Java
Stars
1.5k
Forks
772
Avg merge
1h 44m
Merged PRs (30d)
1

Description

As synthtool's template does not call `.kokoro/install_dependencies.sh `, I had to exclude ci.yaml from synthtool's management: https://github.com/googleapis/google-api-java-client/pull/1699/files#diff-c881f5091bb23fef16e6e6da031e4268bbb11bb3404c1a2c7da8afa53c26f4ecL32.

# What's missing in synthtool's template

## install_dependencies is not called.

How about the following options?

- build.sh to call install_dependencies.sh if it exists
- GitHub actions (ci.yaml) to call install_dependencies.sh if it exists

Does install_dependencies.sh work in Windows?

## Synthtool's template is missing to disable CRLF conversion.

```
- name: git configuration to avoid automatic CRLF conversion
run: |
git config --global core.autocrlf false
git config --global core.eol lf
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.