googleads / googleads/googleads-python-lib
Empty XML nodes incorrectly serialized/deserialized
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 749
- Forks
- 967
- PR merge metrics
- No merged PRs in 30d
Description
Seems like this zeep issue is impacting Ad Manager:
https://github.com/mvantellingen/python-zeep/issues/923
Specifically, video line items with an empty requestPlatformTargeting. Reading one of these and sending it unchanged in an updateLineItemsRequest fails with NotNullError.NULL @ targeting.requestPlatformTargeting
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked python-zeep issue 923 and reproducing the video line-item case involving an empty requestPlatformTargeting. Trace the read-and-send path for updateLineItemsRequest and determine where the empty XML node changes meaning. Done means an unchanged video line item can be sent without NotNullError.NULL @ targeting.requestPlatformTargeting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100