googleads / googleads/googleads-python-lib

Network Service has is not JSON serializable issue

Abierto
#359 2 comentarios 0 reacciones 1 asignado Ver en GitHub

@christopherseeley ya está trabajando en esto.

Desde el 14/3/2019.

bug P2
Lenguaje dominante
Python
Estrellas
749
Forks
967
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I went from googleads 10 to the newest version of ad manager and now a simple get of all networks associated with a service email account does not work anymore. I get a serialization error with the response. This was not an issue before upgrading. If I downgrade again everything goes back to normal. Is there something I need to do? I've even printed the entire object I'm attempting the json.dumps on and if I copy that into a new script and place it into a json.dumps function it works so there doesn't appear to be anything wrong with the list I'm passing in. This also make it very hard to debug this issue.
Error:

File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/encoder.py", line 184, in default    raise TypeError(repr(o) + " is not JSON serializable")

TypeError: {
    'id': 604966L,
    'displayName': None,
    'networkCode': '203086286',
    'propertyCode': 'ca-pub-3065783271784989',
    'timeZone': 'Europe/Amsterdam',
    'currencyCode': 'EUR',
    'secondaryCurrencyCodes': [],
    'effectiveRootAdUnitId': '202086406',
    'isTest': False
} is not JSON serializable
import services
import json
import flask
from datetime import datetime, timedelta
from pytz import timezone
import pytz
from time import gmtime, strftime
from suds.sudsobject import asdict
NETWORK = ""
dfp = services.ad_manager

def recursive_asdict(data):
   result = {}
   for key, value in asdict(data).iteritems():
       if hasattr(value, '__keylist__'):
           result[key] = recursive_asdict(value)
       elif isinstance(value, list):
           result[key] = []
           for item in value:
               if hasattr(item, '__keylist__'):
                   result[key].append(recursive_asdict(item))
               else:
                   result[key].append(item)
       else:
           result[key] = value
   return result

def suds_to_json(data):
   result = []
   if(isinstance(data, list)):
       for item in data:
           if hasattr(item, '__keylist__'):
               result.append(recursive_asdict(item))
           else:
               result.append(item)
       return json.dumps(result)
   return json.dumps(recursive_asdict(data))

def getNetworks():
   return suds_to_json(services.NetworkService.getAllNetworks())

def connect(networkId, method, params=None):
   global NETWORK
   if (NETWORK != networkId):
       services.connectToNetwork(networkId)
       NETWORK = networkId  
    try:
       if(params):
           return method(params)
       return method()
   except Exception,e:
       print e
       if hasattr(e, 'fault'):
           return suds_to_json(e.fault), 400
       else:
           return e, 500

services.py

import credentials
from googleads import ad_manager, oauth2

oauth2_client = oauth2.GoogleServiceAccountClient(credentials.KEY_FILE, oauth2.GetAPIScope('ad_manager'))
dfp_client = ad_manager.AdManagerClient(oauth2_client, credentials.APPLICATION_NAME)
NetworkService = dfp_client.GetService('NetworkService', version=credentials.API_VERSION)

def connectToNetwork(networkId):
    global ReportService
    client.network_code = networkId;
    ReportService = client.GetDataDownloader(version=credentials.API_VERSION)

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.