googleads / googleads/googleads-python-lib

Network Service has is not JSON serializable issue

Open
#359 2 comments 0 reactions 1 assignee View on GitHub

@christopherseeley is already working on this.

Since Mar 14, 2019.

bug P2
Dominant language
Python
Stars
749
Forks
967
PR merge metrics
No merged PRs in 30d

Description

I went from googleads 10 to the newest version of ad manager and now a simple get of all networks associated with a service email account does not work anymore. I get a serialization error with the response. This was not an issue before upgrading. If I downgrade again everything goes back to normal. Is there something I need to do? I've even printed the entire object I'm attempting the json.dumps on and if I copy that into a new script and place it into a json.dumps function it works so there doesn't appear to be anything wrong with the list I'm passing in. This also make it very hard to debug this issue.
Error:

File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/encoder.py", line 184, in default    raise TypeError(repr(o) + " is not JSON serializable")

TypeError: {
    'id': 604966L,
    'displayName': None,
    'networkCode': '203086286',
    'propertyCode': 'ca-pub-3065783271784989',
    'timeZone': 'Europe/Amsterdam',
    'currencyCode': 'EUR',
    'secondaryCurrencyCodes': [],
    'effectiveRootAdUnitId': '202086406',
    'isTest': False
} is not JSON serializable
import services
import json
import flask
from datetime import datetime, timedelta
from pytz import timezone
import pytz
from time import gmtime, strftime
from suds.sudsobject import asdict
NETWORK = ""
dfp = services.ad_manager

def recursive_asdict(data):
   result = {}
   for key, value in asdict(data).iteritems():
       if hasattr(value, '__keylist__'):
           result[key] = recursive_asdict(value)
       elif isinstance(value, list):
           result[key] = []
           for item in value:
               if hasattr(item, '__keylist__'):
                   result[key].append(recursive_asdict(item))
               else:
                   result[key].append(item)
       else:
           result[key] = value
   return result

def suds_to_json(data):
   result = []
   if(isinstance(data, list)):
       for item in data:
           if hasattr(item, '__keylist__'):
               result.append(recursive_asdict(item))
           else:
               result.append(item)
       return json.dumps(result)
   return json.dumps(recursive_asdict(data))

def getNetworks():
   return suds_to_json(services.NetworkService.getAllNetworks())

def connect(networkId, method, params=None):
   global NETWORK
   if (NETWORK != networkId):
       services.connectToNetwork(networkId)
       NETWORK = networkId  
    try:
       if(params):
           return method(params)
       return method()
   except Exception,e:
       print e
       if hasattr(e, 'fault'):
           return suds_to_json(e.fault), 400
       else:
           return e, 500

services.py

import credentials
from googleads import ad_manager, oauth2

oauth2_client = oauth2.GoogleServiceAccountClient(credentials.KEY_FILE, oauth2.GetAPIScope('ad_manager'))
dfp_client = ad_manager.AdManagerClient(oauth2_client, credentials.APPLICATION_NAME)
NetworkService = dfp_client.GetService('NetworkService', version=credentials.API_VERSION)

def connectToNetwork(networkId):
    global ReportService
    client.network_code = networkId;
    ReportService = client.GetDataDownloader(version=credentials.API_VERSION)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.