google / google/s2-geometry-library-java
S1ChordAngleTest Failure
- Dominant language
- Java
- Stars
- 587
- Forks
- 231
- PR merge metrics
- No merged PRs in 30d
Description
I get the following failure when I run `mvn test`:
```
[ERROR] Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.027 s <<< FAILURE! - in com.google.common.geometry.S1ChordAngleTest
[ERROR] com.google.common.geometry.S1ChordAngleTest.testTrigonometry Time elapsed: 0.003 s <<< FAILURE!
junit.framework.AssertionFailedError: expected:<0.15643446504023098> but was:<0.1564344650402278>
at junit.framework.Assert.fail(Assert.java:57)
...
```
Note that, as I mentioned in [issue 43](https://github.com/google/s2-geometry-library-java/issues/43), I had to change the `guava.version` from `32.0-jre` to `32.0.0-jre` in `pom.xml` to get `mvn compile` to succeed. That is the only local diff I have compared to the `master` branch.
In case it's relevant, when I run `java -version`, that returns
```
java version "22.0.1" 2024-04-16
Java(TM) SE Runtime Environment (build 22.0.1+8-16)
Java HotSpot(TM) 64-Bit Server VM (build 22.0.1+8-16, mixed mode, sharing)
```
Contributor guide
Research direction
Start with S1ChordAngleTest.testTrigonometry and reproduce the failure using mvn test under Java 22. Inspect pom.xml, including the guava.version change reported in the issue, and compare the failing numeric assertion with the project’s expected behavior; done means identifying and addressing the cause so the test suite passes consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100