google / google/s2-geometry-library-java

S1ChordAngleTest Failure

Open
#44 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
587
Forks
231
PR merge metrics
No merged PRs in 30d

Description

I get the following failure when I run `mvn test`:

```
[ERROR] Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.027 s <<< FAILURE! - in com.google.common.geometry.S1ChordAngleTest
[ERROR] com.google.common.geometry.S1ChordAngleTest.testTrigonometry Time elapsed: 0.003 s <<< FAILURE!
junit.framework.AssertionFailedError: expected:<0.15643446504023098> but was:<0.1564344650402278>
at junit.framework.Assert.fail(Assert.java:57)
...
```

Note that, as I mentioned in [issue 43](https://github.com/google/s2-geometry-library-java/issues/43), I had to change the `guava.version` from `32.0-jre` to `32.0.0-jre` in `pom.xml` to get `mvn compile` to succeed. That is the only local diff I have compared to the `master` branch.

In case it's relevant, when I run `java -version`, that returns

```
java version "22.0.1" 2024-04-16
Java(TM) SE Runtime Environment (build 22.0.1+8-16)
Java HotSpot(TM) 64-Bit Server VM (build 22.0.1+8-16, mixed mode, sharing)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.