google / google/python-spanner-orm

Support for COMMIT_TIMESTAMP

Open
#77 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
41
Forks
17
PR merge metrics
No merged PRs in 30d

Description

`spanner.COMMIT_TIMESTAMP` is a special value that may be used for automatically setting timestamp fields using commit time. However, the ORM doesn't support this:
```
/usr/local/lib/python3.7/site-packages/spanner_orm/model.py in __init__(self, values, persisted)
462
463 for column in self._columns:
--> 464 self._metaclass.validate_value(column, values.get(column), ValueError)
465
466 for column in self._columns:

/usr/local/lib/python3.7/site-packages/spanner_orm/model.py in validate_value(cls, field_name, value, error_type)
125 cls.fields[field_name].validate(value)
126 except error.ValidationError as ex:
--> 127 raise error_type(*ex.args)
128
129

ValueError: spanner.commit_timestamp() is not of type datetime
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.