google / google/python-spanner-orm

Fix type annotations for Transaction in model.py.

未关闭
#118 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
41
派生
17
PR 合并指标
30 天内没有已合并 PR

描述

Currently `model.py` uses `google.cloud.spanner_v1.transaction.Transaction` for all the transaction parameters, but I think the read-only methods are designed to work with `google.cloud.spanner_v1.snapshot.Snapshot` too. `Snapshot` is available through the Spanner ORM API in `spanner_orm.api.SpannerReadApi.run_read_only()` and `spanner_orm.decorator.transactional_read()`, so we really should support using correct type annotations for `Snapshot`. Another thing to consider is whether there should be any support for `google.cloud.spanner_v1.batch.Batch` in write-only Model methods.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。