google / google/python-fire

Unhandled arguments checked after execution, not before

Ouverte
#168 16 commentaires 27 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
28.2k
Forks
1.5k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Consider a simple program:

```
import fire

def add(a, zero=0):
print('calculating...')
print(a + zero)

if __name__ == '__main__':
fire.Fire(add)
```

And then suppose we make a typo in the argument name, writing ``--zerro`` instead of ``--zero``. This is what I get with fire 0.1.3 under Python 3.6:

```
$ python t.py 1 --zerro 2
calculating...
1
Fire trace:
1. Initial component
2. Called routine "add" (t.py:3)
3. ('Could not consume arg:', '--zerro')

Type: NoneType
String form: None

Usage: t.py 1 -
```

Notice that first we run the code, and only then the error is reported. While I expected the errors to be checked before any user code is executed, because this code could be working for a long time, doing wrong things, etc.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.