google / google/google-sql-syntax-ts

General Issues with formatting result

Aperta
#3 2 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
10
Fork
4
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hi @Ekrekr, I've been following your work in [dataform](https://github.com/dataform-co/dataform), and I was pleasantly surprised to see that this repository existed, as we wanted to understand how formatting works in the BQ UI.

I want to build a VSCode extension and tooling based on this, to standardize SQL formatting and have the same format between `dataform`, `BQ UI` and `Airflow` SQL.

The best formatter currently which is also compatible with jinja is SQLfluff, and produces very good results once configured.

One of our main problems with the current way formatting works is that the result for complex queries is completely unreadable for a human. Ideally the formatter would format based on some standards such as:
- https://www.sqlstyle.guide/
- https://handbook.gitlab.com/handbook/business-technology/data-team/platform/sql-style-guide/

I would be in general interested in forking this and start hacking on it a bit whenever I have time, and/or provide some examples of how the output can be made more readable.

Lastly, I have a general question: would a change/suggestion in here be applied to the Monaco Editor under the BQ UI?

Thank you for taking your time to read this, and sorry for the long wall of text

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.