google / google/google-java-format

IntelliJ Plugin with AOSP inserts incorrect blank lines during optimize imports

Ouverte
#962 3 commentaires 6 réactions 0 personnes assignées Voir sur GitHub
IntelliJ
Langage dominant
Java
Étoiles
6.2k
Forks
937
Merge moyen
6 min
PR mergées (30 j)
3

Description

When using the IntelliJ google-java-formatter 1.16.0.2 with the AOSP style, the "Optimize Imports" action results in empty lines between imports with different TLDs.

### Given:
```java
// ...
import static org.assertj.core.api.Assertions.assertThat;
import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.params.ParameterizedTest;
import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
// ...
```
### Results in:
```java
// ...
import static org.assertj.core.api.Assertions.assertThat;

import lombok.extern.slf4j.Slf4j;

import org.junit.jupiter.params.ParameterizedTest;

import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
// ...
````

### Expected:
When using `spotless:check` with google-java-formatter 0.16.0 / 0.17.0 and AOSP, it complains that all but the first empty line have to be removed. The online documentation [seems to agree](https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing) with spotless.

The IntelliJ plugin does not break the Google Java Style Guide when executing "optimize imports".

### Context
This being inconsistent between spotless and Intellij is very inconvenient. We use use spotless in the CI to enforce the codestyle and this necessitates running `mvn spotless:apply` for every commit or disabling "optimize imports" which itself results in manual cleanup of unused imports.

I have tried it with the default `GOOGLE` style and that does not seem to have this problem.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.