google / google/google-java-format

Misleading message for --dry-run with --replace

Open
#1,094 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.2k
Forks
937
Avg merge
6m
Merged PRs (30d)
3

Description

If you specify both --dry-run (or -n) and --replace (or -replace, -r or -i) you get a message stating "cannot use --dry-run and --in-place at the same time".

The problem is that there is no --in-place option. inPlace is however the internal variable name used for --replace. There's two possible fixes:

1. Change the message. This could affect anything which tries to use the message in some kind of script.
2. Add the --in-place option at line 68 in CommandLineOptionsParser.java and related help text. This should not affect anything else.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.