google / google/eDistantObject

Detail is slightly confusing

Abierto
#239 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Objective-C
Estrellas
176
Forks
36
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi,

Here is a few feedback on https://github.com/google/eDistantObject/blob/master/docs/detail.md
I'm trying to understand it, and thought maybe you'd want some feedback.
I must note I'm new to Objective-C/iOS development, trying to learn (which is why I read the doc)

In the image, what is "v@:"?

Why is the disjunction "value type/reference type" done first in the section "Boxing and Unboxing parameters" and then in "Value Type (pass by value) and Reference Type (pass by reference)". If there is a difference, I don't get it.

In "Boxing and Unboxing Parameters" you state it's a good idea to create a service so that the client can listen to request by the host. Would you mind adding a link to show how to do that? Because this seems absent from the examples of [setup](https://github.com/google/eDistantObject/blob/master/docs/setup.md) or [readme](https://github.com/google/eDistantObject/blob/master/README.md)

> Only a reference to NSObject * is supported and only seen as an out parameter

I find this sentence quite confusing. Where it is supported? I assume you mean that some other things are forbidden. What is forbidden and where? I believe being explicit would help.

> For example, this type can also be seen as a pointer to a c-array of NSObject * and if one is used to iterate over it, it will crash.

What does "one" refere too? And what is "it" (well, I assume that "it" and "one" refers to the same thing)

> and in order to let EDO know it is a value type and passed by value, override -(BOOL)edo_isEDOValueType to returns YES.

I was confused. Because the sentence begin with "all objects". I assume the end of this sentence refers to a single object. In this case, I guess that it would help to rewrite it as:

> in order to let EDO knows that an object `o` must behave as value type and hence be passed by value, you should override its method `-(BOOL)edo_isEDOValueType` to return `YES`.

However, I'm far from sure this is what you meant, so any clarification would help, especially if actually I misunderstood

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Lee docs/detail.md junto con docs/setup.md y README.md, centrándote en los pasajes sobre "v@:", boxing y unboxing, punteros NSObject y tipos de valor EDO. Aclara la terminología y la explicación duplicada, y añade el enlace solicitado a un ejemplo de escucha de servicios si existe un ejemplo adecuado; se considera terminado cuando una persona recién llegada puede entender los casos compatibles y seguir las instrucciones de configuración.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
ios, objective-c
Área
documentation
Tipo de issue
Documentación
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.