google / google/cppdap

Server::start deadlocks on bind failure.

未关闭
#134 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
192
派生
66
PR 合并指标
30 天内没有已合并 PR

描述

It's possible I'm doing something wrong, but I've run into an issue when calling Server::start with an in-use port. A similar issue was reported in #80, but the author closed the ticket without comment.

If you call `Server::start` and bind fails (say a port is already in use), the `start` call never returns. The dead lock happens in the Shared::lock call, which calls shared.reset on failure.

```cpp
// socket.cpp:233
Socket::Socket(const char* address, const char* port)
: shared(Shared::create(address, port)) {
if (shared) {
shared->lock([&](SOCKET socket, const addrinfo* info) {
if (bind(socket, info->ai_addr, (int)info->ai_addrlen) != 0) {
shared.reset(); // Deadlock occurs here.
return;
}

if (listen(socket, 0) != 0) {
shared.reset();
return;
}
});
}
}
```

The Shared::lock method takes a reader lock before calling the function:
```cpp
// socket.cpp:126
template
void lock(FUNCTION&& f) {
RLock l(mutex);
f(s, info);
}
```

The Shared destructor calls close, which at the end attempts to take a writer lock:
```cpp
// socket.cpp:194, bottom of ::close method.
WLock l(mutex);
if (s != InvalidSocket) {
#if !defined(_WIN32) && !defined(__APPLE__)
::close(s);
#endif
s = InvalidSocket;
}
```

That writer lock is waiting for the read lock that is being held by the function calling it, leading to the deadlock.

Am I doing something wrong here? I can work around the issue by trying to bind the socket myself before invoking cppdap and verifying that it works before calling start, but that doesn't seem ideal. The calls to `shared.reset()` inside a call to `shared` seem suspicious to me, but I might well be misreading the code.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。