google / google/codeworld

No special syntax highlighting for common identifiers

Open
#340 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Haskell
Stars
1.3k
Forks
201
PR merge metrics
No merged PRs in 30d

Description

This is a bit of a bikeshed issue, but I’d like to raise it anyways. Feel free to close without much discussion if you disagree.

Currently, CodeWorld syntax highlighting highlights names that happen to be defined in the prelude library (`Double`, `True`) different that names from other libraries (`Event`, `Picture`) or custom-defined things. Similar for function (e.g. `id`).

I generally disapprove of this approach, as it hides the fact that even the Prelude is just a library, and that `Double` and `Event` are both types of their own right. The difference between the two is not worth this distinction, and the type of, say `interactionOf`, looks bad with these types printed differently.

Also, the `Prelude` changes over time, making this highlighting inconsistent.

I’d like to see no special highlighting of predefined identifiers.

Contributor guide

Open the contributing guide

Research direction

Start by locating the CodeWorld syntax-highlighting entry point and the logic that distinguishes Prelude identifiers from names supplied by other libraries or user code. Remove the special highlighting for predefined identifiers, then verify that types and functions such as Double, True, Event, Picture, and id receive the same treatment as other identifiers.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.