deploy: atomically claim and own pending Agent Runtime operations
- Lenguaje dominante
- Python
- Estrellas
- 5.9k
- Forks
- 660
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
## Summary
Agent Runtime deployment operation state in v1.3.1 is a non-atomic read/modify/write record without an owner token. Two CLI processes can both pass the pending-operation check, start remote mutations, and overwrite or clear each other's `deployment_metadata.json` state.
Baseline: `5a306f8956cb1eeae69f9709de0e4d61b44e11e7` (v1.3.1).
## Reproduction
1. In one agent project, start two `agents-cli deploy --no-wait` processes at the same time.
2. Both read the metadata before either writes its pending operation.
3. Observe that both may submit a remote create/update, while the last metadata write wins.
4. Also simulate:
- local SDK request-config construction failing before remote submission;
- remote create/update submission raising with an unknown outcome;
- a delayed status/cleanup process running after a newer operation replaced the record.
## Actual behavior
- More than one remote mutation can start.
- One process can overwrite or clear another process's pending operation.
- A crash between remote submission and operation-name persistence is not represented safely.
- Failure cleanup cannot distinguish known pre-mutation failure from outcome-uncertain remote submission.
## Expected behavior
- Exactly one process owns the right to start a mutation.
- Ownership spans target revalidation, remote submission, status recording, completion, and cleanup.
- Local preparation failure restores prior metadata byte-for-byte.
- Once remote submission or identity creation may have happened, retain a fail-closed `starting` claim for manual reconciliation.
- A stale owner must never clear a replacement owner's record.
- Successful completion should merge current sibling metadata and remove the owned claim in one atomic transition.
## Minimal fix
Use a cross-process lock around metadata read/modify/write, add a random claim ID, claim before remote mutation, revalidate the selected Runtime while holding ownership, and make clear/finish operations owner-aware. Split local request preparation from remote submission so only errors proven to precede mutation restore the previous bytes.
Reference implementation and regressions: [fork Batch 4 branch](https://github.com/benagentai93-dot/agents-cli/tree/codex/batch-4-runtime-identity-sdk-contract).
## Verification evidence
- Thread and subprocess races each produced exactly one owner and exactly one mutation.
- Replacement-owner, legacy-operation, atomic-finish, and sibling-metadata regressions passed.
- Local request-config failure: zero mutation, byte-identical restoration, retry claim succeeds.
- Remote submit and identity-create outcome-uncertain failures retain `state=starting`.
- Fresh targeted review: 35 tests passed; full local suite: 92 passed.
- `ruff check src tests`, `ty check src`, build, and Python 3.11/3.13 installed-wheel smoke tests passed.
Guía de contribución
Línea de trabajo
Comience en la ruta de despliegue de Agent Runtime del baseline y compárela con la rama Batch 4 del fork enlazado, centrándose en las transiciones de read/modify/write de deployment_metadata.json. Ejecute las regresiones de race y fallos de thread/subprocess mencionadas y, a continuación, verifique exactamente un owner y una mutation, una restauración byte-identical para los fallos previos al submit, un estado inicial fail-closed para resultados inciertos y una finalización y limpieza owner-safe.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- cli, cloud
- Tipo de issue
- Error
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100