google / google/adk-python

Dockerfile should first copy requirements.txt and install dependencies before copying agent code

Aperta
#6,923 4 commenti 0 reazioni 2 assegnatari Rivendicata da @Jacksunwei Vedi su GitHub
needs review services
Lingua principale
Python
Stelle
21.5k
Fork
4k
Merge medio
1g 14h
PR unite (30g)
37

Descrizione

https://github.com/google/adk-python/blob/0dbc37d67e928d22acef937a8f441683c88af415/src/google/adk/cli/cli_deploy.py#L203

In the current structure of the Dockerfile, the build first creates a layer with the agent's code, and then creates another layer with the installed dependencies. This order of operations causes the build process to re-create the dependencies layer after every code change, even if the list of dependencies in the requirements.txt hasn't changed.

The correct order should be:
1. copy only requirements.txt file.
2. run pip install to download dependencies
3. copy agent code

This should reduce the amount of time it takes to build container images when redeploying updated agent code, as long as the dependencies list doesn't change.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.