google / google/adk-python

adk deploy: handle non-python dependencies (npx, typescript mpcs, etc)

Aperta
#1,473 2 commenti 0 reazioni 2 assegnatari Rivendicata da @klateefa Vedi su GitHub
mcp needs review tools
Lingua principale
Python
Stelle
21.5k
Fork
4k
Merge medio
1g 14h
PR unite (30g)
37

Descrizione

I've deployed my agent to Google Cloud Run using `adk deploy`.
But now, I find that `npx` (used for a MCP Tool) was not installed; and even if it was, the mcp typescript server I was using will be downloaded and installed every time the Cloud Run Backend is restarted.

I think we could add 'external' (non python) deps [easily into the Dockerfile](https://github.com/google/adk-python/blob/c04adaade118be242fcf110e24e96253ac6550ab/src/google/adk/cli/cli_deploy.py#L23) by just having a new `requirements.sh` that will be ran if present; like [what we're doing](https://github.com/google/adk-python/blob/c04adaade118be242fcf110e24e96253ac6550ab/src/google/adk/cli/cli_deploy.py#L176-L192) with `requirements.txt`

If you think this makes sense, I could send a PR

Thanks

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.