google / google/adk-python-community

feat(memory): add MongoDBMemoryService with Atlas Vector Search support

Abierto
#169 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
182
Forks
75
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Motivation

The community repo has memory service proposals for Valkey (#155/#156), Milvus (#69), Firestore (#38), and SQL backends (#99), but no MongoDB-backed memory service. MongoDB is one of the most widely deployed document databases, and MongoDB Atlas provides native vector search (`$vectorSearch`), making it a natural backend for agent long-term memory with semantic recall.

Related: #31/#32 add a MongoDB *session* service. This proposal is complementary — a `MemoryService` implementation for long-term memory retrieval, not session/state storage. If #32 merges, the two modules together would give ADK users a full MongoDB persistence story.

## Proposed API

A `MongoDBMemoryService` implementing ADK's `BaseMemoryService` interface:

- `add_session_to_memory(session)` — extracts session events, generates embeddings via a pluggable embedding function, and stores documents (`app_name`, `user_id`, `session_id`, `content`, `embedding`, `timestamp`) in a configurable collection
- `search_memory(app_name, user_id, query)` — semantic retrieval via Atlas `$vectorSearch` with top-k limits, similarity threshold, and app/user isolation via pre-filters; falls back to Atlas text search for deployments without a vector index

Configuration options: connection string, database/collection names, embedding function, vector index name, `top_k`, similarity threshold.

## Dependencies

- `pymongo>=4.15,<5.0` (matching the pin in #32) as an optional dependency under a `[mongodb]` extra

## Testing Plan

- Unit tests (mocked client): cover all public methods, edge cases, error conditions
- Integration tests: run against the `mongodb/mongodb-atlas-local` Docker image (supports vector search locally), covering vector similarity search, user/app isolation, top-k limits, distance threshold filtering, metadata preservation, and index idempotency

---

I'd like to implement this myself and will follow the module structure and contribution lifecycle in CONTRIBUTING.md. Happy to adjust the approach based on maintainer feedback.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza con CONTRIBUTING.md y la estructura de módulos existente en torno a la interfaz BaseMemoryService. Revisa los métodos públicos propuestos, la dependencia opcional de pymongo y el plan de pruebas con mocks y Atlas-local Docker. Se considera completado cuando el servicio de memoria de MongoDB cubra los comportamientos enumerados de recuperación, aislamiento, filtrado, metadatos, errores e índices.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
docker, mongodb, python
Área
backend, databases
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.