google / google/GoogleSignIn-iOS

Missing Localization

未关闭
#71 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Objective-C
星标
750
派生
282
平均合并
2 天 15 小时
30 天内合并 PR
9

描述

### "The user canceled the sign-in flow." is not localized.

**Defined on line 108 in GIDSignIn.m**
```
static NSString *const kUserCanceledError = @"The user canceled the sign-in flow.";
```

**Set on line 504 in GIDSignIn.m**
```
errorString = kUserCanceledError;
```

**Added to the error dictionary falsely identifying the string as localized on line 772 in GIDSignIn.m**
```
NSDictionary *errorDict = @{ NSLocalizedDescriptionKey : errorString };
```

Screen Shot 2021-11-12 at 5 19 15 PM

As a side note, "Unknown error" will also never be localized if set on line 770 in GIDSignIn.m.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。