google / google/GoogleSignIn-iOS

Missing Localization

Open
#71 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Objective-C
Stars
750
Forks
282
Avg merge
2d 15h
Merged PRs (30d)
9

Description

### "The user canceled the sign-in flow." is not localized.

**Defined on line 108 in GIDSignIn.m**
```
static NSString *const kUserCanceledError = @"The user canceled the sign-in flow.";
```

**Set on line 504 in GIDSignIn.m**
```
errorString = kUserCanceledError;
```

**Added to the error dictionary falsely identifying the string as localized on line 772 in GIDSignIn.m**
```
NSDictionary *errorDict = @{ NSLocalizedDescriptionKey : errorString };
```

Screen Shot 2021-11-12 at 5 19 15 PM

As a side note, "Unknown error" will also never be localized if set on line 770 in GIDSignIn.m.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.