google / google/GoogleSignIn-iOS

Map alternate scope names in `addScopes`

未关闭
#599 1 条评论 1 个 reaction 已指派 1 人 已被 @w-goog 认领 在 GitHub 查看
bug
主要语言
Objective-C
星标
750
派生
282
平均合并
2 天 15 小时
30 天内合并 PR
9

描述

**Describe the bug**
When calling `addScopes`, the [check against the existing granted scopes](https://github.com/google/GoogleSignIn-iOS/blob/6ad8c90700ecb28d645c8ff76535732f89c38315/GoogleSignIn/Sources/GIDSignIn.m#L382) doesn't normalize the names. If the [core scopes](https://developers.google.com/identity/protocols/oauth2/scopes#google-sign-in) are passed in using their short names (`email`, `openid`, `profile`), the SDK will prompt unnecessarily, because the granted scopes appear to use [the v2 names](https://developers.google.com/identity/protocols/oauth2/scopes#oauth2).

Obviously this can be easily worked around from the client side by not making that call in the first place, but it creates some unexpected complexity in the Flutter wrapper (see https://github.com/flutter/flutter/issues/184872), which has to bridge across the iOS, Android, and Web sign in APIs (which are all quite different). We can work around it at the wrapper level, but it would be nice if the SDK handled this name mismatch internally.

**To Reproduce**
Steps to reproduce the behavior:
1. Sign in.
2. Call `addScopes:...` with `[@"email", @"openid", @"profile"]` as the scopes.
3. See a user prompt.

**Expected behavior**
Receive `kGIDSignInErrorCodeScopesAlreadyGranted`, since AFAICT signing in grants those scopes automatically, but under different names.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。