google / google/GoogleSignIn-iOS

Remove Access To App For Google SSO on Settings isn't working as expected.

Offen
#58 1 Kommentar 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Objective-C
Sterne
750
Forks
282
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
9

Beschreibung

Hello, I am seeing an issue when I try to Remove Access To our app for Google SSO on Settings page(i.e. [link](https://myaccount.google.com/permissions?continue=https%3A%2F%2Fmyaccount.google.com%2Fdata-and-privacy)).

**Here is what i did:**
1.) Sign in with Google SSO on my app.
2.) Put my app to background or killed the app.
3.) Sign in to google on browser with the same gmail account i used in step 1 & Go to Data & Privacy Page(i.e. [link](https://myaccount.google.com/permissions?continue=https%3A%2F%2Fmyaccount.google.com%2Fdata-and-privacy))
4.) Remove access for my app in Data & Privacy Page(i.e. [link](https://myaccount.google.com/permissions?continue=https%3A%2F%2Fmyaccount.google.com%2Fdata-and-privacy))
5.) Get my App to Foreground or Relaunching the app.
6.) During App coming to Foreground or Relaunch, In didFinishLaunchingWithOptions of App Delegate, I do check for `GIDSignIn.sharedInstance.restorePreviousSignIn` to see if Google SSO tokens are still valid.
7.) GIDSignIn.sharedInstance.restorePreviousSignIn returns that the **google sso idTokens** are **still valid** for my app, in my case it shouldn't be as I removed access for my app.

**Conclusion:**
I think this should be the correct behavior, `GIDSignIn.sharedInstance.restorePreviousSignIn` should return **error** or **nil user** when user removes access for an app and tries to `GIDSignIn.sharedInstance.restorePreviousSignIn `, because that is how it worked for Apple & Facebook SSO.

Would love to hear your thoughts or feedback on this, Thank you!.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.