google / google/GoogleSignIn-iOS

Clean up callback flow for sign-in and verify flow.

未关闭
#427 0 条评论 0 个 reaction 已指派 1 人 已被 @brnnmrls 认领 在 GitHub 查看
enhancement
主要语言
Objective-C
星标
750
派生
282
平均合并
2 天 15 小时
30 天内合并 PR
9

描述

Issue found in: https://github.com/google/GoogleSignIn-iOS/pull/414#discussion_r1607303702

The current sign-in and verify flow are brittle when processing the authorization response. The current flow will depend on an `[authFlow wait]` to ensure a token request is made before moving forward. Doing so makes the code harder to understand and easy to break. A way to improve this is by adding completion callbacks to ensure a `tokenRequest` is made before returning an instance of `GIDAuthFlow.`

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。