google / google/GoogleSignIn-iOS

Clean up callback flow for sign-in and verify flow.

Open
#427 0 comments 0 reactions 1 assignee Claimed by @brnnmrls View on GitHub
enhancement
Dominant language
Objective-C
Stars
750
Forks
282
Avg merge
2d 15h
Merged PRs (30d)
9

Description

Issue found in: https://github.com/google/GoogleSignIn-iOS/pull/414#discussion_r1607303702

The current sign-in and verify flow are brittle when processing the authorization response. The current flow will depend on an `[authFlow wait]` to ensure a token request is made before moving forward. Doing so makes the code harder to understand and easy to break. A way to improve this is by adding completion callbacks to ensure a `tokenRequest` is made before returning an instance of `GIDAuthFlow.`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.