google / google/GoogleSignIn-iOS

GIDSignIn.sharedInstance.restorePreviousSignIn is not working as expected

Offen
#346 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @camden-king Auf GitHub ansehen
enhancement
Vorherrschende Sprache
Objective-C
Sterne
750
Forks
282
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
9

Beschreibung

**Describe the bug**

I've been using 'GoogleSignIn' version '4.1.1' for many years and didn't have any trouble.Recently I've updated to '7.0.0' because the older version does not support the Apple Silicon.Back on the '4.1.1' I've been using `GIDSignIn.sharedInstance().signInSilently()` to sign in the user that is already signed in.Then in the delegate method I was catching any kind of error.One of these errors is **_expired token_**.And on the older version everything was working perfect as a swiss watch while the newest version seems to have some troubles with catching errors **_on time_**.If I use '4.1.1' and I force sign out a Google account session with an app using this library everything works perfect, the delegate method handles immediately an error after the first `GIDSignIn.sharedInstance().signInSilently()` attempt, while the newest version where I'm forced to use this method:

```
GIDSignIn.sharedInstance.restorePreviousSignIn { user, error in
if error != nil || user == nil {
self.service.authorizer = nil
} else {
self.service.authorizer = user?.fetcherAuthorizer
}
}
```

does not catch any kind of error and returns user without error as if everything is okay and no force sign out was done which leads to a bad user experience because app acts like if user is signed in, while actually not.The most interesting part is that after about 1 hour this method starts returning error saying "expired token", but again _**after waiting one hour**_.Does this method really supposed to give me an error about expired token after one hour and if so how to detect this error immediately without waiting so much time?

**To Reproduce**
Steps to reproduce the behavior:
1. Sign in inside your app.
2. Force sign out your app session from Devices section in the Security tab of your Google account settings.
3. Restart the app, the app will act like the token is not expired, unable to show you any kind of data.
4. Wait 1 hour but don't push Sign Out button in the app, just wait, after 1 hour `restorePreviousSignIn` method will return the error so the app will act like it should.
**Even the test app has this issue, if you will sign out like in the step 2 and you will restart the test app it will show you that you are signed in...**

**Expected behavior**
I guess giving me the error immediately like the `sign(_ signIn: GIDSignIn!, didSignInFor user: GIDGoogleUser!, withError error: Error!)` method does in the version '4.1.1' without giving to a user any kind of bad experience.

**Environment**
- Device: [ iPhone XS Max]
- OS: [iOS 17.0 ]
- Pod version: [ 7.0.0]

1)
2)
3)
4)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.