google / google/CodeCity

Address python style issues in MobWrite server

Aperta
#201 1 commento 0 reazioni 1 assegnatario Rivendicata da @NeilFraser Vedi su GitHub
Lingua principale
JavaScript
Stelle
198
Fork
38
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The MobWrite server is written in python, and was adopted by CodeCity. It has numerous python style issues, raised in PR #198, including:

- Extensive use of global variables.
- Generally poor object-orientation / encapsulation.
- Unnecessarily complicated `__init__` signatures.
- Using `try`/`finally` instead of `with` for locking, etc.

Rewrite it conform to [the style guide](https://github.com/google/styleguide/blob/gh-pages/pyguide.md) (or alternatively rewrite it to conform to [the *other* style guide](https://google.github.io/styleguide/jsguide.html)).

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.