google / google/CodeCity

Address python style issues in MobWrite server

Open
#201 1 comment 0 reactions 1 assignee Claimed by @NeilFraser View on GitHub
Dominant language
JavaScript
Stars
198
Forks
38
PR merge metrics
No merged PRs in 30d

Description

The MobWrite server is written in python, and was adopted by CodeCity. It has numerous python style issues, raised in PR #198, including:

- Extensive use of global variables.
- Generally poor object-orientation / encapsulation.
- Unnecessarily complicated `__init__` signatures.
- Using `try`/`finally` instead of `with` for locking, etc.

Rewrite it conform to [the style guide](https://github.com/google/styleguide/blob/gh-pages/pyguide.md) (or alternatively rewrite it to conform to [the *other* style guide](https://google.github.io/styleguide/jsguide.html)).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.