google-deepmind / google-deepmind/mujoco_mpc

a proposal on updating agent state info before mj_step in PhysicsLoop of app.cc

Open
#344 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.7k
Forks
282
PR merge metrics
No merged PRs in 30d

Description

as following (line 359), what do you say about adding sim.agent->state.Set(m, d); before mj_step.
my reason is that , controller need instant state info to control robot, instant time info is good for interpolating right control info, or it will be failed in some hard scenarios.
截屏2024-09-25 17 26 35
i am not sure about this suggestion, because the performance does not improve yet.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.