google-deepmind / google-deepmind/dm_control

Respect MJCF path processing and XML include specifications

Abierto
#111 1 comentario 6 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
4.7k
Forks
764
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

From the MuJoCo docs:

> The full path to a file is determined as follows. If the strippath attribute described above is "true", all path information from the file name is removed. The following checks are then applied in order: (1) if the file name contains an absolute path, it is used without further changes; (2) if this attribute is set and contains an absolute path, the full path is the string given here appended with the file name; (3) the full path is the path to the main MJCF model file, appended with the value of this attribute if specified, appended with the file name.

This is applies to included files, which must be treated as if they were part of the document including them. `dm_control.mjcf`, however, ignores this and treats all paths _relative to the file(s) being included_.

Take the following example:

/root/foo.xml
```xml

...

```
/root/common/skybox.xml
```xml



...
/>

```

This example (were it filled out entirely) compiles successfully using MuJoCo, but fails when using `dm_control.mjcf` which looks for `right.png` in `/root/common/skyboxes/`. It appears the root problem is in `parser.py` which doesn't propagate the the fact that `skybox.xml` was included.

This means the MJCF models in dm_control are incompatible with other MuJoCo-dependent libraries and vice-versa.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.