gitui-org / gitui-org/gitui

UX: Wherever Arrow keys may scroll or switch to other view, switch only if no scroll happened in last 0.5 s

Aperta
#2,898 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
feature-request
Lingua principale
Rust
Stelle
22.5k
Fork
773
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### The Problem

In a number of views, Arrow keys allow to scroll contents horizontally and/or vertically. Those views include full screen diff (`Up`/`Down`) or commit message body (`Up`/`Down`). However, those views are also left by the same Arrow key if you're at the edge already and press the key once more.

UX wise, this overloading is problematic, because scrolling is often used with autorepeat, which unintendedly runs into the other view too easily.

In the case of the commit message body, there's no way for the user to separate switching from scrolling, other than paying high attention to the tiny scroll bar and slowing down near the end.

In the case of full screen diff, the problem has been [mitigated](https://github.com/gitui-org/gitui/issues/1729#issuecomment-1677802949), for the time being, by _disabling_ `Left` as a way to leave. However, that workaround [comes at a price](#1729) of its own, as it breaks "Lynx mode" navigation.

### Suggested Solution

Wherever a view area can be left by an Arrow key that also is used to scroll that view's content, perform the switch only if there hasn't been any input from the specific key in the last 0.5 s. (Time window may be adjusted.)

This ensures that switching generally works instantly (as opposed to an hard delay), whilst only in conflicting moments there's a barrier that prevents autorepeat from running too far.
In the latter case, simply pressing the key anew suffices to switch views if indeed intended.

### Considered Alternatives

Alternatively, different keys could be bound to scrolling vs. switching by default. However, Arrow keys make a lot of sense for both (even if for mostly distinct user groups).

### Additional Context

This FR is based on a [suggestion](https://github.com/gitui-org/gitui/issues/1729#issuecomment-1824749242) by [@smammy](https://github.com/smammy) on how to safely re-enable Arrow key back navigation in full screen diff.

However, just like the underlying problem, the solution is more general, and should be applied globally to all scrollable views.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia tracciando la gestione dei tasti freccia nel diff a schermo intero, nel corpo del messaggio di commit e nelle altre viste scorrevoli per identificare dove lo scorrimento e il cambio di vista condividono l’input. Implementa e verifica la protezione di 0,5 secondi per tasto, in modo che lo scorrimento non attivi la navigazione durante la ripetizione automatica, mentre un tasto appena premuto continui a cambiare vista quando previsto.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
rust
Ambito
cli
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.