gitui-org / gitui-org/gitui

Support opening inside of Helix

Aperta
#2,556 6 commenti 11 reazioni 0 assegnatari Vedi su GitHub
feature-request good first issue
Lingua principale
Rust
Stelle
22.5k
Fork
774
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Yazi (A file explorer written in Rust) recently [added support for using `yazi` right inside of Helix via `:insert-output`](https://github.com/sxyazi/yazi/pull/2461)

You can use Lazygit right inside of Helix as well. This is described in the Helix wiki (https://github.com/helix-editor/helix/wiki/Recipes#git-integration)

I wanted to try out `gitui`. So I gave it a shot and wow its about 3x faster (benchmark: undoing changes for 1,200 files). So I want to use it now. I tried using it in Helix's `:insert-output` but it does not work.

`:insert-output` uses Helix's [`shell_impl_async`](https://github.com/helix-editor/helix/blob/b38eae1f98f63607af43e63852ff8488d8916d68/helix-term/src/commands.rs#L6163-L6228) to turn the output of the passed `cmd: &str` and display it in the editor

You can check Yazi's PR on how they implemented it and it may be implemented here in a similar way.

`:insert-output gitui` would ideally allow you to use `gitui` right within Helix, but at the moment it just freezes the screen.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Use Helix's shell_impl_async in helix-term/src/commands.rs, at the referenced lines, as the integration entry point, and compare Yazi PR 2461's approach. Reproduce the freeze with :insert-output gitui, then verify that gitui opens and remains usable inside Helix without freezing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
git, rust
Ambito
cli, developer-experience
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.