gitui-org / gitui-org/gitui

Cannot commit with empty e-mail.

Open
#2,178 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
22.5k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When git is configured with an empty e-mail address, `gitui` does not allow commits.

**To Reproduce**
Steps to reproduce the behavior:
```
git config --global user.email "<>"
git init foo
cd foo
echo "some content" > a_file.txt
gitui
# Stage a_file.txt
# Hit "c" to start a commit
# Type any commit message and hit enter
```

**Expected behavior**
A new commit should be created.

**Screenshots**
![image](https://github.com/extrawurst/gitui/assets/1566372/7cafc4d2-2f3b-4d9e-8e50-7e95643fb7bd)

**Context (please complete the following information):**
- Fedora 39
- GitUI 0.24.3
- Git 2.44.0

Contributor guide

Open the contributing guide

Research direction

No source files or tests are named. First reproduce the failure with the listed git config, repository, staging, and commit steps, then trace gitui's commit flow for handling an empty email. Done means a commit is created successfully with an empty configured email, with coverage for this scenario if the existing test structure supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.