gitui-org / gitui-org/gitui

edit only for head revision otherwise open as tempfile

Open
#2,147 0 comments 0 reactions 0 assignees View on GitHub
feature-request good first issue
Dominant language
Rust
Stars
22.5k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

right now we show a `edit [e]` cmd for any file at any revision in file tree views. but we only open the file as it is currently on disk.

this means you don't see then what you expected when you looked at an old diff/revision. or worst case: the file is no longer present and will error.

we should only show `edit [e]` when you are at the head revision and otherwise two other options:
1. `open [o]` which will dump the revision of the file in a tempfile and open that
2. `go to head [g]` to jump the that file in the current file-tree (if it present)

2. is not as trivial and should probably be a separate issue (feel free to open that)

Contributor guide

Open the contributing guide

Research direction

Start in the file-tree view handling for the existing `edit [e]` command and trace how a selected revision is opened. Limit the change to showing edit only at the head revision and opening older revisions through the proposed `open [o]` tempfile behavior; treat `go to head [g]` as separate work. Done means old revisions open successfully without depending on the current on-disk file.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.