Respect git environment variables when committing
- Lingua principale
- Rust
- Stelle
- 22.5k
- Fork
- 773
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
**Describe the bug**
According to https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables git uses environment variables as primary source for name and email configuration.
> The final creation of a Git commit object is usually done by git-commit-tree, which uses these environment variables as its primary source of information, falling back to configuration values only if these aren’t present.
**To Reproduce**
Steps to reproduce the behavior:
1. Set:
```
export GIT_COMMITTER_NAME="Your Name"
export GIT_AUTHOR_EMAIL="git@example.com"
export GIT_COMMITTER_EMAIL="git@example.com"
export GIT_AUTHOR_NAME=Your Name"
export EMAIL="git@example.com"
```
2. Commit something with `git commit`
3. See in the logs that the env var values were used
4. Commit something with gitui
5. See in the logs that the git configured user was used instead.
**Expected behavior**
As git docs explains, environment variables should be used as primary source for the git commit command. If the variables are not configured we fall back to git configuration values.
**Screenshots**
Not applicable
**Context (please complete the following information):**
- OS/Distro + Version: Ubuntu 20.04.5
- GitUI Version: gitui 0.22.1
- Rust version: No idea, I use the package from the Nix package manager
**Additional context**
Even though it's suboptimal it's quite common that humans share users on certain machines, when working with Git it's nice to be able to send GIT_* and EMAIL over SSH to Git and gitui 😄
Workaround: Stage with gitui, commit with git (Same workaround as signing commits).
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia dal punto di ingresso dei commit di gitui e segui come vengono selezionati i valori dell’identità dell’autore e del committer per `git commit`. Confronta questa selezione con le variabili Git GIT_AUTHOR_NAME, GIT_AUTHOR_EMAIL, GIT_COMMITTER_NAME, GIT_COMMITTER_EMAIL ed EMAIL, quindi riproduci il comportamento segnalato tra ambiente e configurazione per verificare il risultato.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- git, rust
- Ambito
- cli
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100