github / github/vscode-github-actions

False positive missing-required-inputs for app_location when action: "close" in Azure Static Web Apps deploy

Abierto
#609 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
660
Forks
213
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Bug report

**Describe the bug**

The extension reports a `missing-required-inputs` error for `app_location` on the
`close_pull_request_job` pattern recommended by Azure Static Web Apps. The workflow
runs successfully in CI — the error is a false positive.

`Azure/static-web-apps-deploy@v1` marks `app_location` as `required: true` in its
`action.yml`, but the field is only meaningful when `action: "upload"`. When
`action: "close"`, the action ignores `app_location` entirely and completes without it.

**Steps to reproduce**

Use the standard close-PR job that Azure's own onboarding wizard generates, with GitHub Actions extension installed:

```yaml
build_and_deploy_job:
if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
runs-on: ubuntu-latest
name: Build and Deploy Job
permissions:
id-token: write
contents: read
steps:
- uses: actions/checkout@v4
with:
submodules: true
lfs: false
- name: Build And Deploy
id: builddeploy
uses: Azure/static-web-apps-deploy@v1
with:
azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}
repo_token: ${{ secrets.GITHUB_TOKEN }}
action: "upload"
app_location: "/"
#api_location: "api"
output_location: "dist"

close_pull_request_job:
if: github.event_name == 'pull_request' && github.event.action == 'closed'
runs-on: ubuntu-latest
name: Close Pull Request Job
steps:
- name: Close Pull Request
id: closepullrequest
uses: Azure/static-web-apps-deploy@v1
with:
azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}
action: "close"

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza localizando la validación de entradas de GitHub Actions que lee el action.yml de Azure/static-web-apps-deploy@v1 y reproduce el flujo de trabajo close_pull_request_job mostrado aquí. El trabajo estará terminado cuando action: "close" ya no informe de que falta app_location, mientras que el patrón de carga siga validando sus entradas obligatorias.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions, typescript
Área
developer-experience
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
58/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.