github / github/vscode-github-actions

CMD+Tab on mac submits input for workflow run

Open
#454 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
While prompted to enter an input after triggering a workflow that requires inputs, pressing cmd+tab out of vscode to look up a value submits the input (as though you hit enter).

**To Reproduce**
Steps to reproduce the behavior:
1. Select 'Trigger workflow' button on any workflow that has a workflow_dispatch handler with inputs. You will see a dialogue to enter the input.
2. Press cmd+tab to switch to a different window, then switch back to the vscode window.
3. The initial input dialogue is gone and is now prompting for the next input if there is one, or has triggered the workflow if that was the last input.

**Expected behavior**
The workflow input does not get submitted when pressing cmd+tab

**Screenshots**
Dialogue I'm referring to:
Image

**Extension Version**
`v0.27.1`

Contributor guide

Open the contributing guide

Research direction

Reproduce this in VS Code using a workflow_dispatch workflow with multiple inputs, then trace the workflow trigger input dialog handling in the extension. Verify that switching away with CMD+Tab and returning leaves the current input open, without advancing or triggering the workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.