github / github/vscode-github-actions

diagnostics not cleared when file is closed

Open
#376 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

The extension doesn't clear the editor diagnostics for a specific file when the file is closed, and diagnostics are persisted until the entire editor is closed, or the window reloaded.

For false-positives/non-issues like the one reported in #375, that means that whenever I open a workflow/action `.yml` file, the "Problems" pane is populated with non-actionable diagnostics, and I have no way to clear it unless I close the `.yml` file and reload the editor or the extension host.

**Expected behavior**:
The extension clears all diagnostics related to a file when it is closed, and only display diagnostics for actively opened files.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how the extension creates and updates diagnostics for opened workflow/action .yml files, then reproduce the issue by opening and closing one. Done means diagnostics for a closed file are cleared while diagnostics for actively opened files remain visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.