github / github/vscode-github-actions

Incorrect version in package-lock.json triggers false positive for critical security vulnerability

Open
#356 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

In `~/.vscode-server/extensions/github.vscode-github-actions-0.26.3/script/workspace/package-lock.json`:

```
"vscode-github-actions": {
"version": "0.25.6",
```

So it looks like the declared version in the lock file (0.25.6) is older than the package version (0.26.3).

This in turn gets flagged in `grype`:

```
vscode-github-actions 0.25.6 npm GHSA-wvmr-x489-hcpj Critical
```

Which is quite the false alarm, given the severity of that particular issue:

https://github.com/advisories/GHSA-wvmr-x489-hcpj

Contributor guide

Open the contributing guide

Research direction

Inspect ~/.vscode-server/extensions/github.vscode-github-actions-0.26.3/script/workspace/package-lock.json and compare the vscode-github-actions entry with the package version 0.26.3. Check the result with grype; done means the lock file no longer reports version 0.25.6 or triggers the cited false vulnerability finding.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.