github / github/vscode-github-actions
Linter lints old version when comparing diffs
- Linguagem predominante
- TypeScript
- Estrelas
- 660
- Forks
- 213
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior:
1. Create & **commit** the following workflow:
```yaml
# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
name: Build
on:
pull_request:
branches:
- main
permissions:
contents: read
jobs:
build:
name: Build
runs-on: ubuntu-latest
outputs:
build_id: ${{ steps.build.build_id }}
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
show-progress: false
- name: Build
id: build
shell: bash
run: |
echo "Building"
echo "build_id=12345" >> "$GITHUB_OUTPUT"
```
1. Notice the linting warning on `${{ steps.build.build_id }}`: `Context access might be invalid: build_id`.
1. Delete the following lines, save but do NOT commit:
```yaml
outputs:
build_id: ${{ steps.build.build_id }}
```
1. In the diff window compare the changes
1. (BUG 1) (while diff is open) Notice the LEFT window showing the linting warning, which also shows up under 'PROBLEMS'

1. (while diff is open) Double click the warning under problems and notice it opens a locked (denoted the padlock next to the name) version of the previous, unedited version of `build.yaml`.

1. Close the diff & locked old version of `build.yaml`
1. (BUG 2) Notice the linting error is still there under 'PROBLEMS'

1. (BUG 2 related) When double clicking linting warning it opens up the same locked (denoted the padlock next to the name) version of the previous, unedited version of `build.yaml`.
1. (BUG 1) Now when hitting 'CTRL+P' to switch between files there are 2 entries for `build.yaml` which are indistinguishable, yet refer to different versions:

**Expected behavior**
Only errors on the new version are reported.
**Screenshots**
See reproduction
**Extension Version**
`v0.26.2`
**Additional context**
Add any other context about the problem here.
Guia de contribuição
Direção de pesquisa
Nenhum arquivo-fonte ou teste é especificado. Reproduza o fluxo de trabalho no VS Code com a extensão v0.26.2 e, em seguida, rastreie como os diagnósticos e os documentos abertos são associados enquanto o diff é exibido e depois que ele é fechado. Está concluído somente quando apenas a versão editada relata erros, os avisos não abrem um arquivo antigo bloqueado e o alternador de arquivos não tem entradas duplicadas.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- github-actions, typescript, vscode
- Domínio
- devtools, tooling
- Tipo de issue
- Bug
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 35/100