github / github/vscode-github-actions

Indentation switches from 2 to 4 spaces if a step uses `env:` or `with:`

Abierto
#231 1 comentario 3 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
660
Forks
213
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Describe the bug**

If a job contains a step which uses `env:` or `with:` then the indentation on subsequent lines switches from 2 spaces to 4 spaces. The issue seems to only persist for the rest of the given job and resets in the next one.

**To Reproduce**

1. Start out with this file

```yaml
on: push

jobs:
test:
runs-on: ubuntu-latest

steps:
- name: Step 1
run: echo "step 1"

#- name: Step 2

- name: Step 3
uses: actions/checkout@v2
with:
foo: bar

#- name: Step 4

- name: Step 5
uses: echo "step 5"
env:
foo: bar

#- name: Step 6

- name: Step 7
run: echo "step 7"
```
3. Uncomment step 2, go to the end of the line, press enter then tab, start to type `run:`
5. The resulting text should be aligned with `name` from the line above it
6. Uncomment step 4, go to the end of the line, press enter then tab, start to type `run:`
7. The resulting text will not be aligned with `name` from the line above it, instead it will be indented an extra 2 characters
8. Uncomment step 6, go to the end of the line, press enter then tab, start to type `run:`
9. The resulting text will not be aligned with `name` from the line above it, instead it will be indented an extra 2 characters

**Expected behavior**

The second line of step's 4 and 6 to be aligned with the line above it.

**Screenshots**

https://github.com/github/vscode-github-actions/assets/831974/7c202f2d-a1f3-4097-9735-5cc474eb625c

**Extension Version**

`v0.25.8`

**Additional context**

1. The issue goes away if you switch the file's language from `github-actions-workflow` to `yaml`
2. Adding the following to my vscode settings file doesn't help:

```json
"[github-actions-workflow]": {
"editor.tabSize": 2,
"editor.insertSpaces": true,
},
```
3. The issue happens with and without GitHub Copilot running

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Reproduce the issue in VS Code using the github-actions-workflow language mode and the YAML workflow shown in the report, especially steps containing env: or with:. Compare indentation after pressing Enter and Tab following those mappings. Done means subsequent step properties remain aligned with the preceding name line, as they do when the file uses the yaml language mode.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
tooling
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.