github / github/vscode-github-actions

Invalid syntax highlighting with or condition `||`

Ouverte
#224 2 commentaires 7 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
TypeScript
Étoiles
660
Forks
213
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
Syntax is invalid formatted with `||` at the begging of the line

**To Reproduce**
Steps to reproduce the behavior:
This workflow casuses invalid hightlighting on the last line:
```yaml
name: "CI / CD"

on: workflow_call

jobs:
prepare:
name: "Prepare"
runs-on: "ubuntu-22.04"
outputs:
perform-tests: "${{ steps.should-perform-tests.outputs.perform-tests }}"
perform-lint: "${{ steps.should-perform-lint.outputs.perform-lint }}"

steps:
- name: "Should perform tests"
id: "should-perform-tests"
run: |
echo "perform-tests=1" >> $GITHUB_OUTPUT

- name: "Should perform lint"
id: "should-perform-lint"
run: |
echo "perform-lint=1" >> $GITHUB_OUTPUT

ci:
name: "CI"
runs-on: "ubuntu-22.04"
needs: ["prepare"]
if: >
needs.prepare.outputs.perform-lint == 1
|| needs.prepare.outputs.perform-tests == 1
```

**Expected behavior**
The last line shouldn't be red and slanted.

**Screenshots**
![image](https://github.com/github/vscode-github-actions/assets/35669512/7ffd37b4-46ff-48f9-8d75-20d965ac55ee)

**Extension Version**
`v0.25.8`

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

No source files or tests are named. Reproduce the provided workflow in VS Code with the GitHub Actions extension, starting from the syntax-highlighting behavior around the multiline `if` expression; done means the line beginning with `||` is no longer shown red and slanted.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
github-actions, typescript, vscode
Domaine
developer-experience, tooling
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.