github / github/vscode-github-actions

Invalid syntax highlighting with or condition `||`

Open
#224 2 comments 7 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Syntax is invalid formatted with `||` at the begging of the line

**To Reproduce**
Steps to reproduce the behavior:
This workflow casuses invalid hightlighting on the last line:
```yaml
name: "CI / CD"

on: workflow_call

jobs:
prepare:
name: "Prepare"
runs-on: "ubuntu-22.04"
outputs:
perform-tests: "${{ steps.should-perform-tests.outputs.perform-tests }}"
perform-lint: "${{ steps.should-perform-lint.outputs.perform-lint }}"

steps:
- name: "Should perform tests"
id: "should-perform-tests"
run: |
echo "perform-tests=1" >> $GITHUB_OUTPUT

- name: "Should perform lint"
id: "should-perform-lint"
run: |
echo "perform-lint=1" >> $GITHUB_OUTPUT

ci:
name: "CI"
runs-on: "ubuntu-22.04"
needs: ["prepare"]
if: >
needs.prepare.outputs.perform-lint == 1
|| needs.prepare.outputs.perform-tests == 1
```

**Expected behavior**
The last line shouldn't be red and slanted.

**Screenshots**
![image](https://github.com/github/vscode-github-actions/assets/35669512/7ffd37b4-46ff-48f9-8d75-20d965ac55ee)

**Extension Version**
`v0.25.8`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.