github / github/vscode-github-actions

Input key checks are unnecessarily case-sensitive

Offen
#106 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
TypeScript
Sterne
660
Forks
213
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

**Describe the bug**
There are a lot of contexts whose possible input keys are case insensitive. For example, both `secrets.BANANA` and `secrets.banana` work just fine (from the [github secrets docs](https://docs.github.com/en/actions/security-guides/encrypted-secrets#naming-your-secrets): "Names are not case-sensitive."). This applies to secrets, with blocks, and many more. The extension currently erroneously reports an error when not using the same casing as the definition

**To Reproduce**
Steps to reproduce the behavior:
1. Create repo secret called "BANANA"
2. Use secret via secrets.banana

**Expected behavior**
No error is reported

**Screenshots**
![image](https://github.com/github/vscode-github-actions/assets/45497981/dcb25ab1-1dba-4757-b10e-549d77498181)

**Extension Version**
`v0.25.4`

**Additional context**
-

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by locating the extension's validation logic for input keys, especially references to secrets and with blocks. Reproduce the reported case with a definition named BANANA and a reference to secrets.banana; done means no error is reported for case differences in supported case-insensitive contexts.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
github-actions, typescript
Bereich
ci-cd, developer-experience
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.