github / github/terraform-github-runner-vnet

Update Terraform to match new requirements for immutable actions

Abierto
#3 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
HCL
Estrellas
7
Forks
6
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The below email went out about immutable actions going GA. We need to update the Terraform for the new documented NSG rules and hostnames.

https://docs.github.com/en/enterprise-cloud@latest/admin/configuring-settings/configuring-private-networking-for-hosted-compute-products/configuring-private-networking-for-github-hosted-runners-in-your-enterprise#prerequisites

> With the upcoming GA of [Immutable Actions](https://app.github.media/e/er?s=88570519&lid=6887&elqTrackId=2089613d1975440cba49cf1699d19312&elq=e8faad9f5a2649f09c612135dd5b536f&elqaid=4301&elqat=1&elqak=8AF5F83217BACB33C82BDA01DE29C845613B20B406C5BCB8005B1C13E7A3A7DD8887), Actions will now be stored as packages in the GitHub Container Registry. We are reaching out because your runners currently cannot access one or both of the required domains.
>
> Please ensure that your self-hosted runner allow lists are updated to accommodate the network traffic. Specifically, you should allow traffic to pkg.actions.githubusercontent .com to ensure Immutable Actions can be downloaded successfully and jobs don’t fail during setup. If you already allow *.actions.githubusercontent .com which is listed as a required [domain](https://app.github.media/e/er?s=88570519&lid=6884&elqTrackId=b7f11ed639fe4100ad273ddeeba717db&elq=e8faad9f5a2649f09c612135dd5b536f&elqaid=4301&elqat=1&elqak=8AF5C9C07190433D254390100DD088133C3220B406C5BCB8005B1C13E7A3A7DD8887) then no action is necessary. Traffic will also be required to ghcr .io for publishing new versions of an Immutable Action in the future, which will be available with the GA release.
>
> This update also affects runners in all versions of [GitHub Enterprise Server](https://app.github.media/e/er?s=88570519&lid=6886&elqTrackId=eea39858328e46ea8c49f65a7e7cbb28&elq=e8faad9f5a2649f09c612135dd5b536f&elqaid=4301&elqat=1&elqak=8AF5BA3D777FF49C74C2C5A980F48BC782EA20B406C5BCB8005B1C13E7A3A7DD8887) that use the [GitHub Connect](https://app.github.media/e/er?s=88570519&lid=6885&elqTrackId=2d4e8de21bdb4c3ab2c7d560daef8e1d&elq=e8faad9f5a2649f09c612135dd5b536f&elqaid=4301&elqat=1&elqak=8AF5919B165BDBDFBB56C205DC45E742C0A720B406C5BCB8005B1C13E7A3A7DD8887) feature to download actions directly from [github.com](http://github.com/). Customers are advised to update their self-hosted runner network allow lists accordingly. For further guidance on communication between self-hosted runners and GitHub, please refer to our [documentation](https://app.github.media/e/er?s=88570519&lid=6884&elqTrackId=22ddb4d8053f43f79a6abfede75ff273&elq=e8faad9f5a2649f09c612135dd5b536f&elqaid=4301&elqat=1&elqak=8AF52EEB92063F91403EC85E81F4CEFE25A020B406C5BCB8005B1C13E7A3A7DD8887).
>
>
> Additionally, our guidance for configuring Azure private networking has been updated to account for the new domains. The following IP addresses have been added to the NSG template in our [documentation](https://app.github.media/e/er?s=88570519&lid=6883&elqTrackId=e725ffdc135546de852f74dd95586c74&elq=e8faad9f5a2649f09c612135dd5b536f&elqaid=4301&elqat=1&elqak=8AF5E22CEABE3C14167980E8DF365B77FF5020B406C5BCB8005B1C13E7A3A7DD8887).
>
> [140.82.121.33/32](http://140.82.121.33/32)
> [140.82.121.34/32](http://140.82.121.34/32)
> [140.82.113.33/32](http://140.82.113.33/32)
> [140.82.113.34/32](http://140.82.113.34/32)
> [140.82.112.33/32](http://140.82.112.33/32)
> [140.82.112.34/32](http://140.82.112.34/32)
> [140.82.114.33/32](http://140.82.114.33/32)
> [140.82.114.34/32](http://140.82.114.34/32)
> [192.30.255.164/31](http://192.30.255.164/31)
> [4.237.22.32/32](http://4.237.22.32/32)
> [20.217.135.1/32](http://20.217.135.1/32)
> [4.225.11.196/32](http://4.225.11.196/32)
> [20.26.156.211/32](http://20.26.156.211/32)

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start in the terraform-github-runner-vnet repository by locating the NSG template and hostname allow-list definitions, then compare them with the linked GitHub hosted-runner private-networking prerequisites. The work is done when the documented Immutable Actions domains and listed IP ranges are represented in the Terraform configuration and the module's validation checks pass.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
terraform
Área
cloud, infrastructure
Tipo de issue
Nueva funcionalidad
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.