github / github/secure_headers
Set default `frame-ancestors` on default Content-Security-Policy
- Vorherrschende Sprache
- Ruby
- Sterne
- 3.2k
- Forks
- 253
- Ø Merge
- 19 Std. 11 Min.
- Gemergte PRs (30 T.)
- 1
Beschreibung
We should consider setting a default `frame-ancestors` directive for the Content Security Policy. The [`frame-ancestors`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors) directive is the new iteration of the X-Frame-Options header, and as such setting a directive in both spots might be prudent.
https://github.com/github/secure_headers/blob/b134eef07d3741b4bd0769b863961b41af5df57d/lib/secure_headers/headers/content_security_policy_config.rb#L97
Since our default XFO policy is `sameorigin`, if we decide to take upon this task, we should set the default `frame-ancestors` value to be `self`.
Some counterpoints: setting both the `X-Frame-Options` and the `frame-ancestors` directive will cause the XFO header to be overriden by the frame-ancestors directive. This means that if a user is trying to change some framing functionality, and only changes the XFO header, they might be confused as to why the functionality didn't actually change.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.